A New Testbed for MASM32 Forum

[Antariy]

Works fine on my machine, Win XP SP2 with Celeron M.

Which version of ML did you use?

[Antariy]

Frank, the culprit is:

you are entangle the DWORDs and WORDs:

Code Select Expand


    INVOKE DisplayAt, WORD PTR AlgoColDesc, WORD PTR AlgoRow, ADDR AlgoDesc,
                      DWORD PTR AlgoDescSize


Fix this.

Addeded later:

I found 24 times of that mistypeing. After fixing them - results is showed. But color of CPU string - is not :P
Needed to much deeper search.

ML 10 push them as DWORD - other MLs - as WORD.

[frktons]

Frank, the culprit is:

you are entangle the DWORDs and WORDs:

Code Select Expand


    INVOKE DisplayAt, WORD PTR AlgoColDesc, WORD PTR AlgoRow, ADDR AlgoDesc,
                      DWORD PTR AlgoDescSize


Fix this.

Did you try it? Does it work? Why it is working with ML 10 if it is an error?

Frank

[Antariy]

Frank, the culprit is:

you are entangle the DWORDs and WORDs:

Code Select Expand


    INVOKE DisplayAt, WORD PTR AlgoColDesc, WORD PTR AlgoRow, ADDR AlgoDesc,
                      DWORD PTR AlgoDescSize


Fix this.

Did you try it? Does it work? Why it is working with ML 10 if it is an error?

Re-read previous post carefully :P

[frktons]

Re-read previous post carefully :P

Again:

Did you try it? Does it work? Why is it working with ML 10 if it is an error?

I see the DWORD and WORD are mixed, but you did not answer my questions.

Frank

[Antariy]

Re-read previous post carefully :P

I see the DWORD and WORD are mixed, but you did not answer my questions.

That is general rule: you should use machine-word sized params at least. Even if you use WORD - proc will assume that DWORD is placed into stack, and will free 4 bytes, not 2.
You should not use constructions like "push word ptr [xxx]" "invoke XXX, word ptr [xxx]" etc.

Stall stand misaligned with any further surprices...

Did you try it?

Of course, I test it.

Yes, I tried it, it works. If you re-read previous-previous :) post, then you will see, that founded 24 times of this stuff, after fixing to DWORD - tests runs and timings showed. But color of the outputted string is not changed.

Try to use DWORDs instead of BYTEs and WORDs params/args.

Why is it working with ML 10 if it is an error?

ML 10 push them as DWORD - other MLs - as WORD.




Alex

[jj2007]

Works fine on my machine, Win XP SP2 with Celeron M.

Which version of ML did you use?

ML 6.15 and 9.0 assemble, Jwasm throws 6*Error A2071: Label is expected
ML 6.15 shows an empty display, 9.0 fills it with timings

[Antariy]

ML 6.15 and 9.0 assemble, Jwasm throws 6*Error A2071: Label is expected
ML 6.15 shows an empty display, 9.0 fills it with timings

So, Frank can see, what I not joked or tried to confuse him. I just tried to help...

Jochen, ML 9.0. is change colors of the strings (OS, CPU etc) to yellow, too?

[frktons]

That is general rule: you should use machine-word sized params at least. Even if you use WORD - proc will assume that DWORD is placed into stack, and will free 4 bytes, not 2.
You should not use constructions like "push word ptr [xxx]" "invoke XXX, word ptr [xxx]" etc.

Stall stand misaligned with any further surprices...

Did you try it?

Of course, I test it.

Yes, I tried it, it works. If you re-read previous-previous :) post, then you will see, that founded 24 times of this stuff, after fixing to DWORD - tests runs and timings showed. But color of the outputted string is not changed.

Try to use DWORDs instead of BYTEs and WORDs params/args.

Why is it working with ML 10 if it is an error?

ML 10 push them as DWORD - other MLs - as WORD.

Alex

As I guessed you found the problem and the solution yourself.  :P

Well, I'll change all the WORD into DWORD  :U so people using previous versions
can compile it without errors.

Frank

[frktons]

Fixed version.  :bg

[Antariy]

Code Select Expand


   LOCAL sysinfo:SYSTEM_INFO
   LOCAL szBuild[N16]:BYTE <----- THIS
   LOCAL szBuf[128]:BYTE


size of szBuild buffer should be enlarged to 24 bytes. That is not case, but for future.

[Antariy]

The new one is print timings, but still don't change color of the text - all text is printed as white.

[frktons]

Code Select Expand


   LOCAL sysinfo:SYSTEM_INFO
   LOCAL szBuild[N16]:BYTE <----- THIS
   LOCAL szBuf[128]:BYTE


size of szBuild buffer should be enlarged to 24 bytes. That is not case, but for future.

Well, that is not code that I have written, it should be inside some MACRO I use probably.

The new one is print timings, but still don't change color of the text - all text is printed as white.

The routine for changing the colors is quite simple, maybe it uses the same BYTE or WORD stuff.
Yes:

Code Select Expand


SetColorTo     PROTO ForeGroundColor:BYTE, BackGroundColor:BYTE



Frank

[Antariy]

Frank, change these variables to:

Code Select Expand


    ChosenColor   dd   ?
    ActualColor   dd   ?


[Antariy]

And make SetColorTo that:

Code Select Expand


SetColorTo PROC Fore:BYTE, Back:BYTE

    xor  eax, eax

    mov  al, Back
    shl  al, 4
    add  al, Fore
    mov  ChosenColor, eax

    invoke SetConsoleTextAttribute, wHnd, ChosenColor

    ret

SetColorTo ENDP


After that (previous post and this post changements) all works fine with ML 8.0 and 6.15

And try to use all variables as DWORDs at least. There is not economy in resources, especially under Windows, but many drawbacks if you use not DWORDs...



Alex