Question about function use

[Gunner]

If I have one parameter to a function and the pointer is already in esi, do I need to push esi?  Both work, but I am guessing the last one is better with a less push?

original:

Code Select Expand


invoke ParseLine, [esi]

ParseLine proc uses esi edi ebx pArray:DWORD

mov esi, pArray


Code Select Expand


call ParseLine

ParseLine proc uses esi edi ebx

mov esi, [esi]


[jj2007]

"Less push" is better. And you don't need "use esi" except if your proc changes esi and you need the old value.

[Gunner]

Good to know!