Hello all ...
I want to use SHGetFileInfo function in masm32 to check icon type of an .exe file whether it is a folder icon or not .
would you please explain its parameter and how to use it ?? especially how to check folder icon ??
if it returns true for folder icon i want to delete it .
Thanks in advance ...
Interesting, I made a little console app to return info. I'm too tired now to make it presentable. Main stuff is :
target db "testfolder",0 ;name of the object we're interested in, can be full path, otherwise in same dir
shfi SHFILEINFO <> ;we will get our info in this structure
invoke SHGetFileInfo, addr targetname, NULL, addr shfi, sizeof shfi, SHGFI_ICON+SHGFI_LARGEICON+SHGFI_ICONLOCATION+SHGFI_TYPENAME
Then the structure gets filled and you get back :
shfi.szDisplayName string with path to the file containing the icon, example : "C:\Windows\system32\imageres.dll"
shfi.szTypeName, string wiith a name of the type of the object, for a folder it is : "File folder"
shfi.iIcon, integer which is the icon index in the file, example, default folder icon is index 1 in imageres.dll
shfi.hIcon, handle to the icon
If you get stuck, I will post a fully working tool tomorrow.
"File Folder" is not working :eek
what is the problem ??
.if shfi.szTypeName == "File folder"
;some code to delete that file
.endif
imageres.dll is not a folder ?
You should use shfi.szTypeName
If you want to delete all folders without a non-default icon, you should also check the icon index.
this is the code portion
.code
start:
.data
TestFolder db "H:\game" , 0
shfi SHFILEINFO <>
FileFolder db "This is a folder icon" , 0
NotFolder db "This is not a folder icon" , 0
.code
invoke SHGetFileInfo , addr TestFolder , NULL , addr shfi , sizeof shfi , SHGFI_ICON + SHGFI_LARGEICON + SHGFI_ICONLOCATION + SHGFI_TYPENAME
.if shfi.szTypeName == "File Folder"
invoke StdOut , addr FileFolder
.else
invoke StdOut , addr NotFolder
.endif
invoke ExitProcess , 0
END start
this line the generating error
Quote
.if shfi.szTypeName == "File Folder"
error:
Quote
error A2084: constant value too large
where is the problem !!! :dazzled:
you can not compare strings using .if/.elseif - use this:
include masm32rt.inc
...
.if rv(szCmp,OFFSET shfi.szTypeName,"File Folder")
or
.if rv(szCmpI,OFFSET shfi.szTypeName,"File Folder")
for more than one string compare you can use the switch$-macro:
switch$ OFFSET shfi.szTypeName
case$ "File Folder"
;...
case$ "WhatEver"
;...
else$
;...
endsw$
Cooool ....
There is another problem ...
i hv placed three .exe file named firefox.exe , updater.exe , ashQuick.exe in a folder and using this code portion :
invoke SHGetFileInfo , addr aline , NULL , addr shfi , sizeof shfi , SHGFI_ICON + SHGFI_LARGEICON +
SHGFI_ICONLOCATION + SHGFI_TYPENAME+SHGFI_USEFILEATTRIBUTES
invoke StdOut , OFFSET shfi.szTypeName
invoke StdOut , OFFSET shfi.iIcon
but there is no difference in output ...
Quote
Application♥
Application♥
Application♥
but all those files icons are different ... :eek
i think output should be different for each different file
what can i do now ?!?!
How many times do I have to say that Typename is the type ? They are all applications ! :naughty:
What's different is the icon index, which you don't print correctly, because that one isn't a string, it's a number, you have to convert it in order to type it. (That's why you're getting those hearts at the output probably, it's not homo from your PC)
Well, this a little test I made, there is a lot of info you can get with that API, maybe later I can show more things, I'm kinda multitasking right now.
This is GoAsm code, but it's very close to MASM you should have no problem, compile as console app. And you can only select files with this, not folders. And ignore, where it says "error" lol
Quote from: maruf10 on February 25, 2010, 02:49:40 PM
... SHGFI_ICON ...
Do not forget to close the icons handle using DestroyIcon().
BTW: it is not a good practise to use '+' for linking flags - use 'or'.
Quote from: qWord on February 24, 2010, 06:45:17 PM
you can not compare strings using .if/.elseif - use this:
include masm32rt.inc
...
.if rv(szCmp,OFFSET shfi.szTypeName,"File Folder")
or
.if rv(szCmpI,OFFSET shfi.szTypeName,"File Folder")
for more than one string compare you can use the switch$-macro:
switch$ OFFSET shfi.szTypeName
case$ "File Folder"
;...
case$ "WhatEver"
;...
else$
;...
endsw$
Hehe can be done with strings of 4 characters or less :]
Quote from: Slugsnack on February 25, 2010, 09:11:16 PM
Hehe can be done with strings of 4 characters or less :]
theoretical any size :bg
mov edi,chr$("Some Size")
assume edi: ptr DWORD
.if [edi] == "emoS" && [edi+4] == "ziS " && WORD ptr [edi+8] == "e"
invoke MessageBox,0,0,0,0
.endif
many many thanks to all...
I have checked BlackVortex's code ....
It outputs same icon index for different .exe file ....
Quote
icon index for vlc.exe == 3
icon index for firefox.exe == 3
icon index for a.pdf == 23
icon index for a.doc == 12
<<
i have to identify those .exe file whose icon is like "File folder"..but if it outputs same result for all .exe file i think it will not be possible to identify .exe folder in this way ...at present there is no .exe folder(files whose icon is like file folder) in my mechine ... so i have not tested it for that kind of file ...
>>
i think for vlc.exe and firefox.exe it should generate diffent output because their icons are different ...
this is the code ... i have converted it to masm32 syntax from goAsm syntax ... hope it is ok ...
.386
.model flat, stdcall
option casemap :none
;include \masm32\include\windows.inc
;include \masm32\include\kernel32.inc
;include \masm32\include\masm32.inc
include \masm32\include\masm32rt.inc
includelib \masm32\lib\kernel32.lib
includelib \masm32\lib\masm32.lib
includelib \masm32\lib\shell32.lib
.data
h_console_in dd 0
h_console_out dd 0
sz_Titlestring db "Select file to get info",0
sz_1 db "Press OK to exit",0
sz_format1 db "Icon in : %s ",13,10,"Type of file : %s",13,10,"Index of the icon : %lu",13,10,0
junk dd 0
namebuffer db 128 dup (?)
buffer db 128 dup (?)
ofn OPENFILENAME <>
shfi SHFILEINFO <>
.code
start:
invoke GetStdHandle, STD_OUTPUT_HANDLE
mov [h_console_out], eax
invoke GetStdHandle, STD_INPUT_HANDLE
mov [h_console_in], eax
mov [ofn.lStructSize],SIZEOF ofn
mov [ofn.lpstrFile], OFFSET namebuffer
mov [ofn.nMaxFile], SIZEOF namebuffer
mov [ofn.lpstrTitle] , OFFSET sz_Titlestring
mov [ofn.Flags], OFN_FILEMUSTEXIST + OFN_PATHMUSTEXIST + OFN_EXPLORER + OFN_HIDEREADONLY + OFN_NOCHANGEDIR
invoke GetOpenFileName , addr ofn
invoke SHGetFileInfo, addr namebuffer, NULL, addr shfi, sizeof shfi, SHGFI_ICON+SHGFI_LARGEICON+SHGFI_ICONLOCATION+SHGFI_TYPENAME
invoke wsprintf, addr buffer, addr sz_format1, addr shfi.szDisplayName, addr shfi.szTypeName, [shfi.iIcon]
invoke WriteConsole, [h_console_out], addr buffer , eax, addr junk, NULL
invoke MessageBox, NULL, addr sz_1, NULL, NULL
invoke ExitProcess,0
END start
:) I have solved string matching problem ....
Yeah, I noticed that,too. I don't understand what kind of icon handle that function returns, anyone have any ideas ?
What's that "system image list" the documentation referes to ?
http://msdn.microsoft.com/en-us/library/bb762179%28VS.85%29.aspx
Anyone got any ideas ?
I think accessing shell32.dll can help ...
i have got this line from winasm.net ...
but don't understand its meaning exactly .....
Quote
invoke GetModuleHandle,CTEXT("Shell32.DLL")
mov Shellhdl,eax
invoke LoadImage, Shellhdl, 160, IMAGE_ICON, 16, 16, LR_SHARED
INVOKE SendDlgItemMessage,hWin,1012,STM_SETIMAGE,IMAGE_ICON,eax
Hi
By winasm have i found this
invoke GetModuleHandle,CTEXT("c:\windows\system32\Shell32.DLL")
invoke LoadImage, eax, 160, IMAGE_ICON, 16, 16, LR_SHARED
invoke SendDlgItemMessage,hWin,1015,STM_SETIMAGE,IMAGE_ICON,eax
(http://img190.imageshack.us/img190/7509/34019512.png)
This draw this icons on a dialog item
the code loads shell32.dll in process to obtain an icon (ordinal=160) from it's resource section. Then it sets the icon to a static controll (it must be created with the SS_ICON-style).
Is it possible to retrive any icon from shell32.dll providing file path ??
I want to compare that icon with "File folder" icon
Quote from: maruf10 on February 27, 2010, 07:05:02 PM
Is it possible to retrive any icon from shell32.dll providing file path ??
not sure what you mean - for system dll's there is no need to specific an path.
Please check this code :
.386
.model flat, stdcall
option casemap :none
;include \masm32\include\windows.inc
;include \masm32\include\kernel32.inc
;include \masm32\include\masm32.inc
include \masm32\include\masm32rt.inc
include \masm32\include\debug.inc
includelib \masm32\lib\kernel32.lib
includelib \masm32\lib\masm32.lib
includelib \masm32\lib\debug.lib
.code
start:
.data
cmd2 db 'cmd /c dir "H:\file\*.exe" /s/w/b/a-d >' ;folder to be checked
;module_name db "C:\windows\system32\shell32.dll",0
dest2 db "H:\go.txt",0
helloworld db " Hello world ", 0
NewLine db 10,13,0
shfi SHFILEINFO <>
.code
invoke wshell , addr cmd2
.data
aline dd 170 dup(0)
spos dd 0
answ dd 0
alen dd 0
lcnt dd 0
temp dd 0
numb dd 0
.code
invoke read_disk_file , addr dest2 , addr answ , addr alen
;invoke GetModuleHandle , offset module_name
.repeat
invoke readline,answ,addr aline,spos
mov temp,eax
.if eax!=NULL
invoke SHGetFileInfo , addr aline , NULL , addr shfi , sizeof shfi , SHGFI_ICON + SHGFI_LARGEICON + SHGFI_ICONLOCATION + SHGFI_TYPENAME+SHGFI_USEFILEATTRIBUTES
invoke StdOut , OFFSET shfi.szTypeName
PrintDec shfi.iIcon
invoke StdOut , OFFSET NewLine
inc lcnt
.endif
mov eax,temp
mov spos,eax
.until eax==0
invoke GlobalFree,answ
invoke wsprintf,addr aline,SADD("lines read=%li"),lcnt
invoke MessageBox,0,addr aline,0,0
invoke ExitProcess,eax
END start
i want to differentiate among various .exe file having different icon ....
i have placed three files 2 having firefox icon in a folder....
but the debug window of this code shows different icon type for that two files ...
i think those output should be same for all same icon type file though their name is different...
where is the error ??
hope you will explain these three lines too : :red
Quote
invoke wshell , addr cmd2
invoke read_disk_file , addr dest2 , addr answ , addr alen
invoke readline,answ,addr aline,spos
Quote from: maruf10 on February 27, 2010, 07:34:10 PM
Quote
invoke wshell , addr cmd2
invoke read_disk_file , addr dest2 , addr answ , addr alen
invoke readline,answ,addr aline,spos
These functions are part of the masm32.lib - for a description look at masm32\help\masmlib.chm.
wshell creates a process of cmd.exe with the parameters
'/c dir "H:\file\*.exe" /s/w/b/a-d >H:\go.txt'.
This list all executables in the folder h:\file\ and redirect ('>') the output to the file go.txt. You can do this also by hand when typing the line into the command window.
Quote from: maruf10 on February 27, 2010, 07:34:10 PM
where is the error ??
there is no error. After a quick google search I've figured out that the index in the System Image List is differently for each item in a folder.
i think Edgar has what you want...
http://www.masm32.com/board/index.php?topic=12313.msg94428#msg94428
Quote
SHGFI_ICON
Retrieve the handle to the icon that represents the file and the index of the icon within the system image list. The handle is copied to the hIcon member of the structure specified by psfi, and the index is copied to the iIcon member.
I hv got this from msdn ...
need some assistance < clear cut example >to implement this because my code is not responding for iIcon .... :red
should i convert the value of iIcon frm int to string ??
it will be devastating for me if it not works :(
using iIcon for comparing will not work, because each icon in a folder has it own index (AFAIKS). Why do you want to compare files by their icons?
just want to check .exe files having folder icon of my pen drive ... exmple : newfolder.exe , new folder.exe etc etc ....
it doesn't matter whether it is important or not ... i just want to delete those files .....
For those files, what does shfi.szDisplayName contain ?
Should be string with path to the file containing the icon, example : "C:\Windows\system32\imageres.dll" for default icons.
Quote
szDisplayName
A string that contains the name of the file as it appears in the Windows Shell, or the path and file name of the file that contains the icon representing the file.
http://msdn.microsoft.com/en-us/library/bb759792%28VS.85%29.aspx
shfi.szDisplayName just displays the file name here :red....
invoke SHGetFileInfo, addr aline, NULL, addr shfi, sizeof shfi, SHGFI_ICON or SHGFI_LARGEICON or SHGFI_ICONLOCATION or SHGFI_TYPENAME or SHGFI_DISPLAYNAME or SHGFI_USEFILEATTRIBUTES
invoke StdOut , OFFSET shfi.szDisplayName
here "aline" is the path to that file
in attachmend an Sample program that compare two icons by using GetDIBits. May it helps you to solve your problem...
The line below is not working in masm32 .....
Quote
invoke CmpIcon,_hIcon1,_hIcon2
which library/header file should i add to use this ??
CmpIcon is inside the source file posted. It's a procedure.
yeah ...
thank u ....
this is really complicated ...
I will try to understand it :)
i just want to implement http://msdn.microsoft.com/en-us/library/bb759792(VS.85).aspx (ftp://http://msdn.microsoft.com/en-us/library/bb759792(VS.85).aspx)
why the output for iIcon of same file is different for different drive/folder??
according to this link it should work ::)
would you please explain the CmpIcon function ?? :red
The function accepts to icon-handles. GetIconInfo() is used to receive bitmaps form these handles. The next step is do get the dimensions of the bitmaps using GetObject(). Here comes the first compare: if the size is not equal the function returns 0, other wise GetDIBits() is used to obtain the pixels as DWORD-array. This two arrays are simply compared using repe cmpsd.
BTW: I've got the feeling that you mean thumbnails when talking about icons.(?)
what is the usage of these lines !!
Quote
LOCAL hdc:HDC
mov hdc,rv(CreateCompatibleDC,rv(GetDC,0))
mov bi.bmiHeader.biSize,SIZEOF BITMAPINFO
this is an offtopici am using this line
Quote
Command db 'cmd /c dir "H:\file\*.exe" /s/w/b/a-d >'
WriteFileName db "C:\myFile.txt",0
invoke wshell , addr Command
to list all .exe file of H:\file path in C:\myFile.txt. i want to take the path as input . if i store the path in Buffer ..how can i execute that Command using Buffer ??
Quote from: maruf10 on March 22, 2010, 07:45:32 PM
what is the usage of these lines !!
Quote
LOCAL hdc:HDC
mov hdc,rv(CreateCompatibleDC,rv(GetDC,0))
GetDIBits required an hDC to get the bits. This DC is compatible to the desktop-window ones (GetDC(0)= desktop-DC).
Quote from: maruf10 on March 22, 2010, 07:45:32 PM
mov bi.bmiHeader.biSize,SIZEOF BITMAPINFO
Quote
The first member of BITMAPINFO-struct must filled with the size of this struct - windows use this to determinate the 'version' of used struct.
Quote from: maruf10 on March 22, 2010, 07:45:32 PMi want to take take the path as input . if i store the path in Buffer ..how can i execute that Command using Buffer ??
look at the szMultiCat-function coming with masmlib. For a description see \masm32\help\masmlib.chm.
Quote
Extension db "*.exe",0
Constraint db " /s/w/b/a-d >'",0
pBuf dd ?
StrBuffer dd 256 dup(?)
mov pBuf,offset StrBuffer
print rv(szMultiCat,4,pBuf, chr$("'cmd /c dir "), edi,addr Extension , addr Constraint)
how can i print a double quote(") after dir and after Extension??
i have used escape character (!) and (\) .
but its not working .. :(
current output : 'cmd /c dir K:\*.exe /s/w/b/a-d >'
link : http://webster.cs.ucr.edu/Page_TechDocs/MASMDoc/ProgrammersGuide/Appendix_A.htm
e.g.: chr$(34,"text",34) -> "text"
alternatively use the cfm$()-macro: cfm$("\qtext\q") -> "text"
I want to get a file icon from it's handle value and show it result to listview with the following code
but it's fail
mov lvi.imask, LVIF_TEXT or LVIF_IMAGE or LVIF_ICON
mov lvi.iSubItem,0
invoke FindWindow,ADDR szWndClass,ADDR szWndText ;WILL RETURN WINHANDLE
invoke SHGetFileInfo,
eax, ;I THINK THE WRONG HERE
NULL,
addr sfi, sizeof sfi,
SHGFI_ICON or SHGFI_ICONLOCATION or SHGFI_USEFILEATTRIBUTES
invoke ImageList_AddIcon, hImageListS, sfi.hIcon
mov lvi.iImage, eax
lea eax,szWndHandle
mov lvi.pszText,eax
invoke SendMessage, hList2, LVM_SETITEM, NULL,addr lvi
invoke DestroyIcon, sfi.hIcon
I think the error avail when I call SHGetFileInfo.
I now I must change eax with the full path of the file who I want to view it's icon.
But what I want is: I want to get it's icon from it's handle and then show it result on listview.
How?
would you like to give me a clue?
Sorry for my bad english
thank you
You want to get the file icon of an executable through an window handle?:
1. Get the window handle
2. get the process id using GetWindowThreadProcessId()
3. Open the process with the PROCESS_QUERY_INFORMATION-right
4. use GetModuleFileNameEx() to get the executable path
5. pass the path to SHGetFileInfo
(6. do not forget to close all handles)
to help troubleshoot, examine the return values for each INVOKE
in many cases, you have to call GetLastError to find the error code
make a routine that displays error messages in a message box and call it whenever that's the case
if the error is returned in EAX, use CALL RegErr
if not, use CALL LastErr
.DATA
ErrStr db 'Error',0
.CODE
LastErr PROC
INVOKE GetLastError
RegErr::
push edi
xor ecx,ecx
sub esp,508
push ecx
mov edi,esp
INVOKE FormatMessage,FORMAT_MESSAGE_FROM_SYSTEM,ecx,eax,ecx,edi,512,ecx
INVOKE MessageBox,NULL,edi,offset ErrStr,MB_ICONERROR
add esp,512
pop edi
ret
LastErr ENDP
it may require a little modification to report winsock errors
this one displays the address of the call in the title bar :P
ErrStr db 'Error at Address xxxxxxxx',0
.CODE
LastErr PROC
INVOKE GetLastError
RegErr::
push esi
push edi
mov edx,[esp+8] ;RET address
sub edx,5 ;subtract CALL length
push eax
mov esi,uhex$(edx)
pop eax
mov edi,offset ErrStr+17
movsd
movsd
xor ecx,ecx
sub esp,508
push ecx
mov edi,esp
INVOKE FormatMessage,FORMAT_MESSAGE_FROM_SYSTEM,ecx,eax,ecx,edi,512,ecx
INVOKE MessageBox,NULL,edi,offset ErrStr,MB_ICONERROR
add esp,512
pop edi
pop esi
ret
LastErr ENDP
called with EAX = 122
(http://img819.imageshack.us/img819/5510/errbox.png)
and, in the code above, i even give you the extra "d" for "address"
....no additional charge
thank's qWord :U
it work. What a long ways!
btw, in PHP, I can split FileName into an array.
Example:
$filename = "file1.asm";
$arr = explode(".", $filename);
echo $arr[0]; // WILL RETURN file1
echo $arr[1]; // WILL RETURN asm
How to do it with masm? what API?
would you like to give me a clue?
thank you
sorry for my bad english
I got it work! :dance:
but I have problem. now
how can we get file icon/ file attribut/ file type/ file time on WEB?
maybe my correct question is:
how use API SHGetFileInfo to get information of file(File icon/ file attribut/ file type/ file time) on NET?
I have try to run the following code but the result like the picture in my attached file.
could somebody give a clue?
thanks
.data?
hFind dd?
.
.
.
LOCAL FindData:WIN32_FIND_DATA
LOCAL hConnect:DWORD
INVOKE FtpFindFirstFile,hConnect,SADD("public_html/*.*"),addr FindData,0,0
.if eax != INVALID_HANDLE_VALUE
mov hFind, eax
xor edi, edi
mov edi,0
.while eax != 0
;.if (FindData.dwFileAttributes & FILE_ATTRIBUTE_HIDDEN)
;.if (FindData.dwFileAttributes & FILE_ATTRIBUTE_SYSTEM)
;.if (FindData.dwFileAttributes & FILE_ATTRIBUTE_READONLY)
;.if (FindData.dwFileAttributes & FILE_ATTRIBUTE_ARCHIVE)
;ID ROW
mov lvi.imask,LVIF_PARAM
push edi
pop lvi.iItem
mov lvi.iSubItem,0
push edi
pop lvi.lParam
invoke SendMessage,hList1,LVM_INSERTITEM,0,addr lvi
;FILE ICON+FILE NAME
mov lvi.imask,LVIF_TEXT or LVIF_IMAGE
mov lvi.iSubItem,0
INVOKE lstrcpy, addr szPath,SADD("public_html")
invoke lstrcat,addr szPath,addr FindData.cFileName
invoke SHGetFileInfo,
ADDR szPath,
0,
ADDR sfi,SIZEOF sfi,
SHGFI_ICON or SHGFI_LARGEICON or SHGFI_DISPLAYNAME
lea eax,FindData.cFileName ;TRY TO GET FILENAME (SUCCESS)
mov lvi.pszText,eax
mov eax,sfi.iIcon ;TRY TO SHOW ICON BUT STILL FAIL
mov lvi.iImage,eax
invoke SendMessage,hList1,LVM_SETITEM,0,addr lvi
;FILE ATTRIBUT
mov lvi.imask,LVIF_TEXT
inc lvi.iSubItem
INVOKE lstrcpy, addr szPath,SADD("public_html")
invoke lstrcat,addr szPath,addr FindData.cFileName
invoke SHGetFileInfo,
ADDR szPath,
NULL,
addr sfi, sizeof sfi,
SHGFI_ICON or SHGFI_LARGEICON or SHGFI_ICONLOCATION or SHGFI_TYPENAME or SHGFI_ATTRIBUTES
lea eax,sfi.dwAttributes ;TRY TO GET FILE ATTRIBUT HERE (BUT FAIL)
;lea eax,sfi.szTypeName ;IF WANT TO GET FILE TYPE(FAIL)
mov lvi.pszText,eax
invoke SendMessage,hList1,LVM_SETITEM,0,addr lvi
inc edi
endsw$
;LOOPING
invoke InternetFindNextFile,hFind,addr FindData
.endw
invoke FindClose,hFind
.else
invoke GetLastError
mov nLastError,eax
invoke FormatMessage,FORMAT_MESSAGE_FROM_SYSTEM,NULL, nLastError, NULL, ADDR szMsgBuff, 128, NULL
invoke MessageBoxEx, NULL, ADDR szMsgBuff, SADD("File Handle invalid"),MB_OK+MB_ICONINFORMATION, LANG_ENGLISH
.endif
mov edi,0